Closed
Conversation
PropertyCallbackInfo<>::This() is now deprecated, HolderV2() is to be used instead.
CodSpeed Performance ReportMerging this PR will degrade performance by 17.94%Comparing Summary
Performance Changes
Footnotes
|
Contributor
Author
|
Closing this PR – solving the issue will be more complex than just using HolderV2(), see #6003 for ongoing work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PropertyCallbackInfo<>::This() is now deprecated, HolderV2() is to be used instead.
Draft for now – causes tests to fail with "TypeError: Illegal invocation: function called with incorrect
thisreference".